Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and remove unsed file. #69

Merged
merged 4 commits into from
Feb 14, 2024

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

@terabytesoftw terabytesoftw changed the title Update dependencies Update dependencies and remove unsed file. Feb 13, 2024
Copy link

what-the-diff bot commented Feb 13, 2024

PR Summary

  • Removal of captainhook.json file
    The file captainhook.json has been removed, which is part of the code clean-up activity to ensure that we keep only relevant and necessary files in our codebase.

  • Change in Version Constraint
    The requirement for the version of "psr/event-dispatcher" in composer.json file was modified. Previously, it strictly required "1.0.0", but now allows any version above "1.0.0" meeting our project compatibility needs.

  • Changes in Mailer.php

    • The manner in which we access the Yii::$container object, a fundamental part of the software structure, has been simplified — the code has been updated from \Yii::$container to Yii::$container.
    • The parameter order of the sendMessage method in Mailer.php was modified. This alteration in sequence of arguments helps improve the method's compatibility and efficiency.
  • Changes in MailerTest.php
    As in Mailer.php, the references to Yii::$container in MailerTest.php were updated to a simpler format, enhancing the code readability for other developers.

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (21f4072) 85.29% compared to head (dfbeb2c) 85.07%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #69      +/-   ##
============================================
- Coverage     85.29%   85.07%   -0.22%     
  Complexity       71       71              
============================================
  Files             4        4              
  Lines           204      201       -3     
============================================
- Hits            174      171       -3     
  Misses           30       30              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samdark samdark merged commit d7fe4ee into yiisoft:master Feb 14, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants